Skip to content

API Reference > Options > Lifecycle Hooks の翻訳 #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 14, 2021
Merged

API Reference > Options > Lifecycle Hooks の翻訳 #460

merged 4 commits into from
Aug 14, 2021

Conversation

naokie
Copy link
Member

@naokie naokie commented Jul 26, 2021

Description of Problem

API Reference > Options > Lifecycle Hooks の翻訳を追加しました。

原文ページ:
https://v3.vuejs.org/api/options-lifecycle-hooks.html

Proposed Solution

Additional Information

@naokie naokie mentioned this pull request Jul 26, 2021
Open
30 tasks
@netlify
Copy link

netlify bot commented Jul 26, 2021 •
edited
Loading

✔️ Deploy Preview for vuejs-v3-ja-doc-preview ready!

🔨 Explore the source changes: 35731c1

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-v3-ja-doc-preview/deploys/611786390d02cc00082cb4fd

😎 Browse the preview: https://deploy-preview-460--vuejs-v3-ja-doc-preview.netlify.app

kazupon
kazupon requested changes Jul 28, 2021
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大変遅くなりました。
レビュー 👀 コメント 💬 しました。
確認お願いします！

src/api/options-lifecycle-hooks.md Outdated

Called when a kept-alive component is activated.
kept-alive コンポーネントがアクティブになったときに呼び出されます。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kept-alive コンポーネントというのはないですね。これ原文もkeep-alive コンポーネントと間違っているので、原文も治す必要がありそうです。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://v3.vuejs.org/api/built-in-components.html#keep-alive
この組み込みコンポーネントのことを指していると思うのですが、やっぱり間違いでしょうか？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

はい、その keep-alive コンポーネントを指しています。
kept-alive は恐らく原文も typo しているので PR チャンスです！

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、typoでしたかw
全然気づかなかったです

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vuejs/docs#1158
PR 出しておきました。

Copy link
Member Author

@naokie naokie Aug 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これは意図的なものだとリプライもらいました。
ソースコードには出てくることなく、テストコードとかを読むとコメントで見つかりますね。

kept-alive コンポーネント（keep-alive の子コンポーネント）がアクティブになったときに呼び出されます。

skirtles-code にリプライもらったとおり、それを説明的にしてこういった訳でどうでしょうか？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど。自分もコード読んで理解しました。
https://github.com/vuejs/vue-next/blob/d045055b475f76624830ed594dd138ac71eccd4e/packages/runtime-core/src/components/KeepAlive.ts#L68

內部で子コンポーネントとして持っていますね。

kept-alive コンポーネント（keep-alive の子コンポーネント）がアクティブになったときに呼び出されます。

もう少し、補足して以下でどうでしょう？

kept-alive コンポーネント（keep-alive が內部で保持する子コンポーネント）がアクティブになったときに呼び出されます。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これに関する詳細についてドキュメントからは探せないので、より説明的になってよいですね！

src/api/options-lifecycle-hooks.md

Called when a kept-alive component is deactivated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここのkept-alive コンポーネントも同様に原文も間違っています。

@naokie @kazupon
fix: the translation of 'patch'
89884c7 
Co-authored-by: kazuya kawaguchi <kawakazu80@gmail.com>
naokie and others added 2 commits July 31, 2021 14:02
@naokie
Copy link
Member Author

naokie commented Aug 14, 2021

kept-alive コンポーネントについて修正したので、再レビューお願いします 🙏🏼

@naokie naokie requested a review from kazupon August 14, 2021 09:01
@kazupon
Copy link
Member

kazupon commented Aug 14, 2021

LGTM!

@kazupon kazupon merged commit 61afc33 into vuejs-jp:lang-ja Aug 14, 2021
@naokie naokie deleted the api/options-lifecycle-hooks branch August 15, 2021 00:28
naokie added a commit to naokie/ja.vuejs.org that referenced this pull request Aug 15, 2021
@naokie
Merge branch 'lang-ja' into api/directives
278e9d1 
* lang-ja: (27 commits)
  docs: translate parts of introduction
  fix: avoid redirects by including .html on links (#1163)
  no filters in vue 3 (#1171)
  feat: enable editLinks (close #1168) (#1172)
  fix: remove unnecessary particles
  Update web-components.md (#1166)
  docs: link to the style guide entry for keyed v-for (#1164)
  3.2 updates (#1157)
  Extended watching multiple sources explanation (#1156)
  Update CONTRIBUTING.md
  API Reference > Options > Lifecycle Hooks の翻訳 (vuejs-jp#460)
  Added the missing JS comma at the end of a line (#1155)
  feat: added cursor pointer to ensure consistency (#1149)
  fix: updated rollup link
  fix: update link for 'SFC State-driven CSS Variables' RFC (#1145)
  docs: document the removal of binding.expression (#1133)
  docs: translate updates about options composition
  docs: update the API entries for mixins and extends (#1146)
  Update introduction.md
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naokie @kazupon